Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Simplified Chinese translation #333

Merged
merged 5 commits into from Feb 14, 2022
Merged

Update Simplified Chinese translation #333

merged 5 commits into from Feb 14, 2022

Conversation

Nyrest
Copy link
Contributor

@Nyrest Nyrest commented Feb 3, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Chinese translation is outdated.

What is the new behavior?

  • Translate new files
  • Improve the existing translation by
    • Make "MenuDisplayName" follow the original expression
  • Ready for review

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@Nyrest Nyrest marked this pull request as ready for review February 5, 2022 06:51
@Nyrest Nyrest changed the title [WIP] Update Simplified Chinese translation Update Simplified Chinese translation Feb 5, 2022
@veler
Copy link
Collaborator

veler commented Feb 5, 2022

Hi,
Thanks you for this update. @Gaoyifei1011, would you like to take a look at it and tell us if it looks good to you, please?

@YuhanKun
Copy link
Contributor

翻译看起来很棒啊,等了好久了还没更新中文有点难受
This looks prertty good.

Copy link
Contributor

@YuhanKun YuhanKun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@YuhanKun YuhanKun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@veler
Copy link
Collaborator

veler commented Feb 14, 2022

Thank you @YuhanKun for confirming :)

@veler veler merged commit 3f58518 into DevToys-app:main Feb 14, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
* Translate new files

* Convert Traditional Chinese to Simplified Chinese

* Fix incorrect translation
Original: "Select which conversion mode you want to use"

* Shorten "MenuDisplayName"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants