Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add refresh button lorem ipsum #413

Merged
merged 6 commits into from Mar 15, 2022
Merged

Feature/add refresh button lorem ipsum #413

merged 6 commits into from Mar 15, 2022

Conversation

Guzzter
Copy link
Contributor

@Guzzter Guzzter commented Feb 18, 2022

Pull request type

Added refresh button to CustomTextBox to enable support for regenerate the action (in this case Lorem Ipsum)

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

To get new Lorem Ipsum text you need to change settings.

Issue Number: #361

What is the new behavior?

Not with the Refresh button you can get new text with single click.

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler linked an issue Mar 1, 2022 that may be closed by this pull request
[Feature Request] Refresh lorem ipsum #361
Closed
veler
veler requested changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you very much for this contribution, and I'm sorry for the delay to look at it. I had a lot of work these past weeks.

Overall, it looks pretty nice. I'd just highly recommend to use a Command instead of an Event in the CustomTextBox for handling the Refresh button. :)

Thank you again!

...dev/impl/DevToys/Views/Tools/Generators/LoremIpsumGenerator/LoremIpsumGeneratorToolPage.xaml Outdated Show resolved Hide resolved
src/dev/impl/DevToys/UI/Controls/CustomTextBox.xaml.cs Outdated Show resolved Hide resolved
src/dev/impl/DevToys/UI/Controls/CustomTextBox.xaml.cs Outdated Show resolved Hide resolved
@Guzzter
Copy link
Contributor Author

Guzzter commented Mar 3, 2022

Hi @veler, I fixed the code with your recommendations. Can you have a look and let know if it is OK? Thanks and have a nice day.

@veler
Copy link
Collaborator

veler commented Mar 3, 2022

Hi @veler, I fixed the code with your recommendations. Can you have a look and let know if it is OK? Thanks and have a nice day.

Hello :)

It looks great! :D Thank you for applying the changes! Let's just address the merge conflict, and we can merge 🗡️
Have a great day!

@veler
Copy link
Collaborator

veler commented Mar 12, 2022

Hello @Guzzter :) If you address the merge conflict, we can merge this PR ;-)
Any chance you can do this soonish, please?

@veler
Copy link
Collaborator

veler commented Mar 15, 2022

Awesome! Thank you very much :D
I will merge it!

@veler veler merged commit b56d954 into DevToys-app:main Mar 15, 2022
@niyari niyari mentioned this pull request Mar 26, 2022
Closed
veler added a commit that referenced this pull request Mar 26, 2022
@youkai95 @veler
@kspc1000 @niyari @Guzzter @GuusBeltman @5idereal @morning4coffe-dev @eurafa @Nyrest
Format from/to custom number base (#430)
cf421ab 
* Number conversion using custom bases functionalities and few tests

* Functionalities to format numbers using any base and dictionary

* Add new language text

* Change models to fit new features

* Add new communication messages between number converter view models

* Add views and functionalities to allow custom dictionaries

* Activate model to receive messages

* Include language generated component

* Rebase and cleanup code

* Update InfoBar message to show/hide it correctly

* Remove remaining code generating compile errors

* Code refactoring

* Fix test cases

* Added the possibility to Favorite/Unfavorite a tool. (#437)

* Added the possibility to Favorite/Unfavorite a tool.

* Updated localization

* addressed feedback

* Fix README.md minor typo (#441)

* Update japanese translation. (#444)

* Bumped up version number

* Feature/add refresh button lorem ipsum (#413)

* Add StartWithLoremIpsum option

* Updated language bundles

* Added refresh buttom for lorem ipsum

* Replaced click handler with Refresh ICommand

* Fixing error

Co-authored-by: Guus Beltman <g_beltman@yahoo.com>

* Added some assets

* Updated chocolatey

* updated wikiUrl in Chocolatey

* Update Traditional Chinese translation (#442)

* Updates to cs-CZ localization (#447)

* feature: 💬 add new lang (Portuguese-Brazil) (#449)

* Update japanese translation. (lorem ipsum) (#450)

* Update japanese translation. (lorem ipsum)

* Fix typo.

* Update chinese translation (#451)

* Added String Escape / Unescape tool (#446)

* Set nullable

* Set nullable and change to string dictionaries

* Fix errors, inject view models and improve code

* Add translations

* Number conversion using custom bases functionalities and few tests

* Functionalities to format numbers using any base and dictionary

* Add new language text

* Change models to fit new features

* Add new communication messages between number converter view models

* Add views and functionalities to allow custom dictionaries

* Activate model to receive messages

* Include language generated component

* Rebase and cleanup code

* Update InfoBar message to show/hide it correctly

* Remove remaining code generating compile errors

* Code refactoring

* Fix test cases

* Set nullable

* Set nullable and change to string dictionaries

* Fix errors, inject view models and improve code

* Add translations

* Automatic input when navigating to the tool

Co-authored-by: Etienne BAUDOUX <ebaudoux@velersoftware.com>
Co-authored-by: kspc1000 <82336379+kspc1000@users.noreply.github.com>
Co-authored-by: Sou Niyari <niyari@users.noreply.github.com>
Co-authored-by: Guus Beltman <guusbeltman@gmail.com>
Co-authored-by: Guus Beltman <g_beltman@yahoo.com>
Co-authored-by: SiderealArt <nelson22768384@gmail.com>
Co-authored-by: Morning4coffe <78549750+morning4coffe-dev@users.noreply.github.com>
Co-authored-by: Rafael Andrade de Oliveira <eurafa@users.noreply.github.com>
Co-authored-by: Boring3 <16686147+Nyerst@users.noreply.github.com>
veler pushed a commit that referenced this pull request Mar 31, 2023
@Guzzter @GuusBeltman
Feature/add refresh button lorem ipsum (#413)
1550f74 
* Add StartWithLoremIpsum option

* Updated language bundles

* Added refresh buttom for lorem ipsum

* Replaced click handler with Refresh ICommand

* Fixing error

Co-authored-by: Guus Beltman <g_beltman@yahoo.com>
veler added a commit that referenced this pull request Mar 31, 2023
@youkai95 @veler
@kspc1000 @niyari @Guzzter @GuusBeltman @5idereal @morning4coffe-dev @eurafa @Nyrest
Format from/to custom number base (#430)
646ceca 
* Number conversion using custom bases functionalities and few tests

* Functionalities to format numbers using any base and dictionary

* Add new language text

* Change models to fit new features

* Add new communication messages between number converter view models

* Add views and functionalities to allow custom dictionaries

* Activate model to receive messages

* Include language generated component

* Rebase and cleanup code

* Update InfoBar message to show/hide it correctly

* Remove remaining code generating compile errors

* Code refactoring

* Fix test cases

* Added the possibility to Favorite/Unfavorite a tool. (#437)

* Added the possibility to Favorite/Unfavorite a tool.

* Updated localization

* addressed feedback

* Fix README.md minor typo (#441)

* Update japanese translation. (#444)

* Bumped up version number

* Feature/add refresh button lorem ipsum (#413)

* Add StartWithLoremIpsum option

* Updated language bundles

* Added refresh buttom for lorem ipsum

* Replaced click handler with Refresh ICommand

* Fixing error

Co-authored-by: Guus Beltman <g_beltman@yahoo.com>

* Added some assets

* Updated chocolatey

* updated wikiUrl in Chocolatey

* Update Traditional Chinese translation (#442)

* Updates to cs-CZ localization (#447)

* feature: 💬 add new lang (Portuguese-Brazil) (#449)

* Update japanese translation. (lorem ipsum) (#450)

* Update japanese translation. (lorem ipsum)

* Fix typo.

* Update chinese translation (#451)

* Added String Escape / Unescape tool (#446)

* Set nullable

* Set nullable and change to string dictionaries

* Fix errors, inject view models and improve code

* Add translations

* Number conversion using custom bases functionalities and few tests

* Functionalities to format numbers using any base and dictionary

* Add new language text

* Change models to fit new features

* Add new communication messages between number converter view models

* Add views and functionalities to allow custom dictionaries

* Activate model to receive messages

* Include language generated component

* Rebase and cleanup code

* Update InfoBar message to show/hide it correctly

* Remove remaining code generating compile errors

* Code refactoring

* Fix test cases

* Set nullable

* Set nullable and change to string dictionaries

* Fix errors, inject view models and improve code

* Add translations

* Automatic input when navigating to the tool

Co-authored-by: Etienne BAUDOUX <ebaudoux@velersoftware.com>
Co-authored-by: kspc1000 <82336379+kspc1000@users.noreply.github.com>
Co-authored-by: Sou Niyari <niyari@users.noreply.github.com>
Co-authored-by: Guus Beltman <guusbeltman@gmail.com>
Co-authored-by: Guus Beltman <g_beltman@yahoo.com>
Co-authored-by: SiderealArt <nelson22768384@gmail.com>
Co-authored-by: Morning4coffe <78549750+morning4coffe-dev@users.noreply.github.com>
Co-authored-by: Rafael Andrade de Oliveira <eurafa@users.noreply.github.com>
Co-authored-by: Boring3 <16686147+Nyerst@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisMtfl DenisMtfl DenisMtfl approved these changes

@veler veler veler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Refresh lorem ipsum
4 participants
@Guzzter @veler @DenisMtfl @GuusBeltman