Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added options to Regex Tester tool #42

Merged
merged 3 commits into from Oct 25, 2021
Merged

Added options to Regex Tester tool #42

merged 3 commits into from Oct 25, 2021

Conversation

veler
Copy link
Collaborator

@veler veler commented Oct 23, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Users are unable to define options to their regex like ECMA Script and Culture Invariant.

Issue Number: #33

What is the new behavior?

Added some options.

image

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler requested a review from btiteux October 23, 2021 20:39
@veler veler added the enhancement Idea of improvement of existing feature. label Oct 23, 2021
@veler veler linked an issue Oct 23, 2021 that may be closed by this pull request
Regex: Consider adding non-inlineable options ECMAScript and CultureInvariant #33
Closed
@veler veler merged commit 97114d2 into main Oct 25, 2021
@veler veler deleted the regex branch October 25, 2021 16:58
veler added a commit that referenced this pull request Mar 31, 2023
@veler
Added options to Regex Tester tool (#42)
eeab922 
* Added UI for options in Regex

* Applied options

* updated language

Co-authored-by: Etienne Baudoux <etbaudou@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btiteux btiteux btiteux approved these changes

Assignees
No one assigned
Labels
enhancement Idea of improvement of existing feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regex: Consider adding non-inlineable options ECMAScript and CultureInvariant
2 participants
@veler @btiteux