New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding certificate encoder decoder tool #803
Adding certificate encoder decoder tool #803
Conversation
I am not sure if the output format is what would be desired. This is basically the default |
04067b0
to
1c0c142
Compare
Wow, what a great pull request! Thank you so much for this! I will need some time to test it myself. Meanwhile, as a heads up, we're working on DevToys 2.0, which will be made in .NET 7.0, and I see there's a specific comment about that. Glad to see .NET 7.0 would hopefully simplify the implementation :D @btiteux, mind taking a look at this PR too? |
...s/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolViewModel.cs
Outdated
Show resolved
Hide resolved
...s/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolViewModel.cs
Outdated
Show resolved
Hide resolved
...s/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolViewModel.cs
Outdated
Show resolved
Hide resolved
Thank you so much. So glad to hear about .NET 7.0! I knew DevToys 2.0 was cooking but I hadn't had a chance yet to see what is in the release. |
Adjusting check for invalid certificate password to compare HResult Moving certificate errors to LanguageManager
Ok hopefully all issues above are addressed now. I have left the commit separate for easy comparison and can squash later after review. |
...iews/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolPage.xaml
Outdated
Show resolved
Hide resolved
...iews/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolPage.xaml
Outdated
Show resolved
Hide resolved
...iews/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolPage.xaml
Outdated
Show resolved
Hide resolved
...iews/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolPage.xaml
Outdated
Show resolved
Hide resolved
...iews/Tools/EncodersDecoders/CertificateEncoderDecoder/CertificateEncoderDecoderToolPage.xaml
Show resolved
Hide resolved
Hello, Again, this PR looks great! Just a few details remaining. |
I just greatly appreciate you taking the time and providing feedback, so please there is no rush. I will have a follow up commit to your latest findings soon. Hope you have safe travels! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved! :D Thank you again for this contribution! Will merge it and wait a few more days before publishing it, just to give a chances to translators to translate this tool in many languages.
Great suggestion, @bobbyben! It is really a privilege to contribute to this awesome repo ❤️ |
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #646
What is the new behavior?
Other information
Quality check
Before creating this PR: