Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding certificate encoder decoder tool #803

Merged
merged 6 commits into from May 10, 2023

Conversation

jlevier
Copy link

@jlevier jlevier commented Apr 21, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • New feature or enhancement
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #646

What is the new behavior?

  • Tool for decoding ssl certificates
  • Can paste raw text or drag and drop / open a file

Other information

dt-cert

dt-cert-1-1

dt-cert-2-1

Quality check

Before creating this PR:

  • Did you follow the code style guideline as described in CONTRIBUTING.md
  • Did you build the app and test your changes?
  • Did you check for accessibility? On Windows, you can use Accessibility Insights for this.
  • Did you verify that the change work in Release build configuration
  • Did you verify that all unit tests pass
  • If necessary and if possible, did you verify your changes on:
    • Windows
    • macOS (DevToys 2.0)
    • Linux (DevToys 2.0)

@jlevier
Copy link
Author

jlevier commented Apr 21, 2023

I am not sure if the output format is what would be desired. This is basically the default .ToString() that .net provides. Maybe we want individual labels and fields? I didn't want to over-complicate the first past on this. Your considerations and suggestions are greatly appreciated.

@jlevier jlevier force-pushed the feature/certificate-encoder-decoder branch from 04067b0 to 1c0c142 Compare April 21, 2023 13:18
@veler veler linked an issue Apr 23, 2023 that may be closed by this pull request
@veler
Copy link
Collaborator

veler commented Apr 23, 2023

Wow, what a great pull request! Thank you so much for this! I will need some time to test it myself.

Meanwhile, as a heads up, we're working on DevToys 2.0, which will be made in .NET 7.0, and I see there's a specific comment about that. Glad to see .NET 7.0 would hopefully simplify the implementation :D

@btiteux, mind taking a look at this PR too?

@jlevier
Copy link
Author

jlevier commented Apr 24, 2023

Thank you so much. So glad to hear about .NET 7.0! I knew DevToys 2.0 was cooking but I hadn't had a chance yet to see what is in the release.

Adjusting check for invalid certificate password to compare HResult
Moving certificate errors to LanguageManager
@jlevier
Copy link
Author

jlevier commented Apr 24, 2023

Ok hopefully all issues above are addressed now. I have left the commit separate for easy comparison and can squash later after review.

@veler
Copy link
Collaborator

veler commented Apr 26, 2023

Hello,

Again, this PR looks great! Just a few details remaining.
As a heads up, I will be traveling from tomorrow to May 9th. This PR is almost ready to be merged. Once done, I'd be happy releasing an update with this new tool, but it will likely not happen before mid-May-ish :D

@jlevier
Copy link
Author

jlevier commented Apr 26, 2023

I just greatly appreciate you taking the time and providing feedback, so please there is no rush. I will have a follow up commit to your latest findings soon. Hope you have safe travels!

Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved! :D Thank you again for this contribution! Will merge it and wait a few more days before publishing it, just to give a chances to translators to translate this tool in many languages.

@veler veler merged commit 59f989f into DevToys-app:main May 10, 2023
1 check passed
@jlevier jlevier mentioned this pull request May 11, 2023
@bobbyben
Copy link

Thanks @jlevier for this great work. It correspond to that i was thinking about in #646
Well done !

@jlevier
Copy link
Author

jlevier commented Aug 2, 2023

Great suggestion, @bobbyben! It is really a privilege to contribute to this awesome repo ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : add SSL cert decoder
3 participants