Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to setup windowLevel #25

Open
asfdfdfd opened this issue Jun 6, 2016 · 9 comments
Open

Allow to setup windowLevel #25

asfdfdfd opened this issue Jun 6, 2016 · 9 comments
Assignees

Comments

@asfdfdfd
Copy link

asfdfdfd commented Jun 6, 2016

Because it may conflict with other libraries. For example https://github.com/terryworona/TWMessageBarManager

@ziogaschr
Copy link
Collaborator

This is a good idea indeed. Can you make a PR on this one?

@asfdfdfd
Copy link
Author

asfdfdfd commented Jun 8, 2016

I could try. But i'm not sure what is the best implementation from architectural point of view. Probably new protocol for such behaviour or maybe just parameter in PasscodeLockConfigurationType.

@ziogaschr
Copy link
Collaborator

I would think it fits nice in PasscodeLockConfigurationType :)

@ziogaschr
Copy link
Collaborator

What do you think of PR #28.
Adding it in PasscodeLockConfigurationType will not be backward compatible :)

@ziogaschr ziogaschr self-assigned this Jun 10, 2016
@asfdfdfd
Copy link
Author

asfdfdfd commented Jun 12, 2016

  1. I think that passcodeLockWindow windowLevel is not enough. Other libraries could change main windowLevel too. And to be in sync it may be better to setup main windowLevel, passcodeLockWindow behind windowLevel and passcodeLockWindow at the front windowLevel;
  2. To maintain backward compatibility default protocol extension could be made. Or new configuration type probably. Not sure which is better.

@ziogaschr
Copy link
Collaborator

I am not so familiar with regards using many windows.
Can you make a PR please with what you think as better?

Thanks a lot for trying to make this library better :)

@asfdfdfd
Copy link
Author

Yes, i'll do. Just have not time for it right now. Will try on next week.

@ziogaschr
Copy link
Collaborator

Thank you

Sent from my iPhone

On 13 ???? 2016, at 01:03, asfdfdfd <notifications@github.commailto:notifications@github.com> wrote:

Yes, i'll do. Just have not time for it right now. Will try on next week.

You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com//issues/25#issuecomment-225463216, or mute the threadhttps://github.com/notifications/unsubscribe/AAw_jKMRqxK7OiSkiTA4GEF_vOl6KFdbks5qLIIRgaJpZM4IvS00.

@asfdfdfd
Copy link
Author

Here it is: #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants