Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implications of payload system #53

Closed
zesterer opened this issue Jul 3, 2018 · 0 comments
Closed

Consider implications of payload system #53

zesterer opened this issue Jul 3, 2018 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@zesterer
Copy link
Contributor

zesterer commented Jul 3, 2018

As of a recent commit, the client moved to a payload system for frontend wishing to add additional payloads of their own to types used inside the client. Currently, we only have a single associated type, but this is ripe for expanding to other areas of the codebase: https://github.com/veloren/game/blob/master/client/src/lib.rs#L60.

We need to think about:

  • Is this a good idea?

  • What implications may it have down the line?

  • Is it worth expanding this to the server and other areas of the codebase?

  • How many other uses does it have?

  • Does it improve or hurt readability?

@zesterer zesterer added the question Further information is requested label Jul 3, 2018
@veloren-bot
Copy link
Member

moved to gitlab https://gitlab.com/veloren/game/issues/16

veloren-bot pushed a commit that referenced this issue Jul 23, 2018
Convert generic Into<String> to &str due to automatic type coercion.

Closes #53

See merge request veloren/game!65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants