Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the choice of chunk size not hard-coded #51

Closed
zesterer opened this issue Jul 2, 2018 · 2 comments · Fixed by #55
Closed

Make the choice of chunk size not hard-coded #51

zesterer opened this issue Jul 2, 2018 · 2 comments · Fixed by #55
Labels
client Relating to the client crate good first issue Good for newcomers voxygen Relating to the voxygen crate

Comments

@zesterer
Copy link
Contributor

zesterer commented Jul 2, 2018

Currently, we use 16 as the chunk size. This is hard-coded in several places (you can search through the changes on 70408ca to find them all). It should be controlled by a single static constant instead.
@zesterer zesterer added good first issue Good for newcomers voxygen Relating to the voxygen crate client Relating to the client crate labels Jul 2, 2018
@ghost
Copy link

ghost commented Jul 3, 2018

I will take this.

@zesterer
Copy link
Contributor Author

zesterer commented Jul 3, 2018

@Treenix Thanks! Also worth noting that the last few commits added instances of this number hard-coded as well. It's probably best to place the static constant in client/src/lib.rs for now since chunks are currently only client-side.

@ghost ghost mentioned this issue Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client Relating to the client crate good first issue Good for newcomers voxygen Relating to the voxygen crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Global constant chunk size
1 participant
@zesterer