Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.vox file validation test #62

Closed
xMAC94x opened this issue Jul 4, 2018 · 3 comments · Fixed by #63
Closed

.vox file validation test #62

xMAC94x opened this issue Jul 4, 2018 · 3 comments · Fixed by #63
Labels
good first issue Good for newcomers voxygen Relating to the voxygen crate

Comments

@xMAC94x
Copy link
Member

xMAC94x commented Jul 4, 2018

we need a test that simply loads all voxel files in the voxygen/vox files and tries to load them into a model.
This way Voxel Artists can know if there is any incompatibility between their uploads and the engine.

The method already exists, you just need to reuse the functions from voxygen/src/game.rs for all those files. and maybe write a test in .gitlab-ci.yaml to automatic run this

@xMAC94x xMAC94x added good first issue Good for newcomers voxygen Relating to the voxygen crate labels Jul 4, 2018
@ghost
Copy link

ghost commented Jul 4, 2018

I would like to take this.

@xMAC94x
Copy link
Member Author

xMAC94x commented Jul 4, 2018

@Treenix can you assign the issue to yourself or doesn't github allows you, because i can nether assign you

@ghost
Copy link

ghost commented Jul 4, 2018

@xMAC94x I can't, since I'm not a collaborator of this repo

@ghost ghost mentioned this issue Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers voxygen Relating to the voxygen crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant