Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaped slashes #12

Closed
mariorovaris opened this issue Jan 27, 2022 · 5 comments
Closed

Escaped slashes #12

mariorovaris opened this issue Jan 27, 2022 · 5 comments

Comments

@mariorovaris
Copy link

Hi!

I'm having problems with slashes in my terms, like when I have html tags.

I would suggest adding JSON_UNESCAPED_SLASHES in this line.
@NaincyKumariKnoldus
Copy link
Contributor

Hey @mariorovaris I really liked to do this and I have raised a PR for this now.
Please review my PR.
Thanks!

@mariorovaris
Copy link
Author

@NaincyKumariKnoldus awesome!
That change will be pretty good
Thanks!

@NaincyKumariKnoldus
Copy link
Contributor

Thankyou so much @mariorovaris

@eldor
Copy link
Contributor

eldor commented Jan 28, 2022

Hi both, thank you for the issue and PR, i'll look into it today.
Just for information, we do suggest to use words or phrases as terms for translations and not including html.

But if there aren't any problems with the PR, ill approve and make a minor version bump.

Have a nice day.

@eldor
Copy link
Contributor

eldor commented Jan 28, 2022

PR #13 merged and tagged 3.0.5

@eldor eldor closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eldor @NaincyKumariKnoldus @mariorovaris