Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It will be very helpfull if user can manually add extra files(or directories) to scan. #3

Closed
nopedev opened this issue Dec 27, 2019 · 4 comments

Comments

@nopedev
Copy link

nopedev commented Dec 27, 2019

Thank you for cool package.
I applied this package to my project and the result is very good.

Except one thing that package scans only *.php and *.vue.

How about the functionality which allows user can manually add files or directories to scan?
something like...

# config/translation.php
...
'extra_files' => [
    resource_path('js/something.js'),
    resource_path('scripts/*.js'),
],
...

I thought that it would be very convenient if this kind of functionality is available.

Thank You.

@eldor
Copy link
Contributor

eldor commented Jan 2, 2020

Thanks for your suggestion.
Will it solve your issue if we extended the config to have extensions selection?

# config/translation.php
...
 'extensions' => ['*.php', '*.vue'],
...

That way you are able to get the scanner du handle .js files as well.

@nopedev
Copy link
Author

nopedev commented Jan 6, 2020

If I have multiple js files in single folder, can I scan only handle.js?

/resources
    /js
        /handle.js
        /somthing.js
        /else.js
        /foobar.js

@eldor
Copy link
Contributor

eldor commented Jan 6, 2020

It could properly be made, but why would you exclude files from scanning?

@eldor
Copy link
Contributor

eldor commented Jan 7, 2020

Added release 1.0.6 where you can select which extensions the scanner scans for.

@eldor eldor closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants