Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn and inject Ultra 0.3.4 when Clojure version is <1.7.0 #50

Closed
venantius opened this issue Dec 30, 2015 · 0 comments
Closed

Warn and inject Ultra 0.3.4 when Clojure version is <1.7.0 #50

venantius opened this issue Dec 30, 2015 · 0 comments
Assignees
@venantius
Labels
bug
Milestone
Ultra 0.4.1

Comments

@venantius
Copy link
Owner

After some thinking on the subject I have decided that the current behavior (where Ultra 0.4.0 causes Leiningen to fail hard when the Clojure version is < 1.7.0) is a pretty garbage user experience. I think a better behavior might be to emit a loud warning on Leiningen startup if the Clojure version is below 1.7.0 and then to fall back to version 0.3.4 so that users still get some of the benefits of Ultra.
@venantius venantius added the bug label Dec 30, 2015
@venantius venantius self-assigned this Dec 30, 2015
@venantius venantius added this to the Ultra 0.4.1 milestone Dec 30, 2015
@venantius venantius changed the title Warn and inject older version of Ultra when Clojure version is <1.7.0 Warn and inject Ultra 0.3.4 when Clojure version is <1.7.0 Dec 30, 2015
@venantius venantius mentioned this issue Feb 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@venantius venantius

Labels
bug
Projects
None yet
Milestone
Ultra 0.4.1
Development

No branches or pull requests
1 participant
@venantius