Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broader coverage of CSS url() #37

Open
gustavohenke opened this issue Mar 24, 2015 · 1 comment
Open

Broader coverage of CSS url() #37

gustavohenke opened this issue Mar 24, 2015 · 1 comment

Comments

@gustavohenke
Copy link

Hey,
Thanks for your great library.

I've seen the code responsible for fixing CSS url()s, and I want to suggest a broader regex.

Two cases that should be taken care of:

  • url( "myfoo.png" ) - spaces are not covered. Maybe \s* is enough
  • url("../fonts/materialdesignicons-webfont.eot?v=1.0.08") - The regex should accept any valid URL, including query strings.

Thank you in advance, and let me know of any further help needed!
@vendethiel
Copy link
Owner

Yes. see also #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vendethiel @gustavohenke