Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Question] Is it possible/how to load QuickCss.css in using the Browser extension? #134

Closed
Spacellary opened this issue Oct 21, 2022 · 14 comments

Comments

@Spacellary
Copy link

Spacellary commented Oct 21, 2022

Question/Issue

Is it possible/how to load QuickCss.css using the Browser extension?
When I open Vencord settings in the browser this is all I see, where is the QuickCss.css file supposed to be placed/located for the web version? The screenshot attached is all I see as options.

Motivation

A pretty Discord.
Vencord is love, Vencord is life.

Vencord web settings page:

msedge_1Yj0E9jZTR

@144reasons
Copy link
Contributor

Hey! QuickCSS doesn't work on browser right now. There are some other CSS editors that you could use like:

@Vendicated
Copy link
Owner

I will implement it either today or tomorrow

@Spacellary
Copy link
Author

Spacellary commented Oct 21, 2022

Amazing news, good stuff.
Thanks all contributors for the continuous improvements in Vencord!
This can be closed as #Completed when that's done by then.
👀

@Vendicated
Copy link
Owner

basically done

simplescreenrecorder-2022-10-21_23.19.52.mp4

I still need to fine tune it and it only works on web for now. Gonna push to monaco branch so if u wanna use it already you can check out that branch (git fetch && git checkout monaco) then build

@Spacellary
Copy link
Author

Nice! 👏

@Vendicated
Copy link
Owner

Scratch that, I pushed to main. Implemented in 4b1e96b

@Vendicated
Copy link
Owner

Please let me know if teverything works fine

@Spacellary
Copy link
Author

Spacellary commented Oct 21, 2022

Please let me know if teverything works fine

Thanks Ven-oniichan-kun-senpai, with Dev Build 4b1e96b everything works fine and looks beautiful ("Modern Discord" theme if anyone else uses that one).

It doesn't work in inPrivate (incognito) mode in MS Edge, but that's not a frequent enough use case for me to matter, just something I noticed, even after allowing the extension in private windows, could be related to rant bellow.

Chromium is so annoying with unpacked extensions, that warning triggers me massively, I ended up having to pack the extension and using the Group Policy editor, after downloading their administrative model, something that's meant for enterprise deployment just be able to manually whitelist my own .crs so it would just behave like a regular extension...

I could have used the Dev or Canary channel but these currently have issues for me and actually even miss a feature I became used to (surprisingly, I know) in the Main channel.

Again, ranting about Chromium aside, it works great!

@144reasons
Copy link
Contributor

It doesn't work in inPrivate (incognito) mode in MS Edge

This happens because if I remember correctly storage between addons arent shared from incognito and... not incognito

@Vendicated
Copy link
Owner

If you mean that your css from normal doesn't transfer over to incognito, that's likely to be expected as I don't use extension storage but instead IndexedDB

@Spacellary
Copy link
Author

Alright I think I understand now, it makes sense. Thanks for clarifying.

@Spacellary
Copy link
Author

Spacellary commented Oct 21, 2022

Ah yes, another thing, when I click the Open QuickCSS FIle button in the inPrivate tab, the window that pops up is blank, not because the address is about:blank as that also happens outside inPrivate windows, but it has no contents or text fields, it's just empty.

Plugins work.

Like this:

msedge_AKCRUjOs96


You know what, this is rather pointless, the settings won't even be saved after you close it anyways, I rest this here. I'm already very happy with the QuickCSS working in my browser already xD

@kiriya-aoi
Copy link

Please let me know if teverything works fine

Seems like it doesn't work with the userscript, just the extension.

@Vendicated
Copy link
Owner

because the userscript doesn't have cps bypass. This is a known limitation for now.

Use the extension or install a cps disabler and enable it for discord (https://github.com/PhilGrayson/chrome-csp-disable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants