Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProductVariant multiple prices for different currencies #13

Closed
michaelbromley opened this issue Aug 30, 2018 · 1 comment
Closed

ProductVariant multiple prices for different currencies #13

michaelbromley opened this issue Aug 30, 2018 · 1 comment
Labels
design 📐 This issue deals with high-level design of a feature

Comments

@michaelbromley
Copy link
Member

Currently a ProductVariant has a price property with a single integer value.

It may be desirable to allow a ProductVariant to have multiple price values, one for each supported currency.

  • One way to achieve this would be to use Channels (see Channels #12) with a separate Channel representing each currency zone.
  • Another approach is like that of Moltin products where the price field is an array of currency-value objects.

In practice, both of the above imply a one-to-many relationship of ProductVariant -> Price objects, in which case we may as well opt for a Channel-based approach, since Channels also unlock other desirable features.

@michaelbromley michaelbromley added the design 📐 This issue deals with high-level design of a feature label Aug 30, 2018
@michaelbromley
Copy link
Member Author

This is now made possible by the underlying implementation of Channels (#12) but still needs the admin ui part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design 📐 This issue deals with high-level design of a feature
Projects
None yet
Development

No branches or pull requests

1 participant