Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native TypeORM softDelete functionality #283

Open
michaelbromley opened this issue Mar 26, 2020 · 1 comment
Open

Use native TypeORM softDelete functionality #283

michaelbromley opened this issue Mar 26, 2020 · 1 comment

Comments

@michaelbromley
Copy link
Member

In #21 I discuss the need for "soft delete" - marking an entity as "deleted" without physically removing it from the database. It is important to preserve the integrity of the data model among other things.

At that time, TypeORM did not have such functionality, so I implemented it in the application logic.

With the latest version of TypeORM, native soft delete is now available. The implementation seems to be very similar to my own, so switching should not be too difficult, and should simplify certain code paths and make things less error-prone.

@michaelbromley
Copy link
Member Author

Note: PR in progess #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant