Revisionable and Mutators

[mmodler]

Hi,

one of my revisionable models has some mutators like getPriceAttribute / setPriceAttribute.

Revisionable's oldValue / newValue irgnores my getter and returns the raw price atrribute?

[duellsy]

This would be because the raw data is what is stored in the revisions table, hence the data that is output is simply

$revision->old_value

I'll have a look and see if there's a way to make it smarter, and output using the mutator if available

[mmodler]

According to the eloquent docs Accessors are named like this:

getFieldnameAttribute

You check for method getFieldname atm, so this can't work for me :)

[duellsy]

Oops... sorry. Fixed up, try that.

[mmodler]

And now also in line 140 - thats the problem with redundant code, as always ;)

[duellsy]

true

[mmodler]

Now the accessor is used. Good! But the main model attributes are not there:

 public function getPriceAttribute() {
    return str_replace('.', ',', $this->attributes['price']);
}

Undefined index: price

[duellsy]

Where are you calling the set method from?
—
Sent from iPhone

On Wed, Aug 7, 2013 at 10:36 PM, mmodler notifications@github.com wrote:

Now the accessor is used. Good! But the main model attributes are not there:

public function setPriceAttribute($price) {
    $this->attributes['price'] = str_replace(',', '.', $price);
}```
Undefined index: price
---
Reply to this email directly or view it on GitHub:
https://github.com/VentureCraft/revisionable/issues/21#issuecomment-22247733

[mmodler]

It happens in my Revision detail controller with

$revision = Revision::find(Input::get('revision_id', null))

[duellsy]

Not sure why that would call the set mutator. Don't suppose you have a full stack trace?
—
Sent from iPhone

On Wed, Aug 7, 2013 at 10:42 PM, mmodler notifications@github.com wrote:

It happens in my Revision detail controller with

$revision = Revision::find(Input::get('revision_id', null))

Reply to this email directly or view it on GitHub:
#21 (comment)

[mmodler]

It really should! If i load a single revision i also want to have nice "mutated" data.

Stack trace:

ErrorException
…/­app/­models/­Seminardate.php34
Illuminate\Exception\Handler handleError
…/­app/­models/­Seminardate.php34
App\Models\Seminardate getPriceAttribute
…/­vendor/­venturecraft/­revisionable/­src/­Venturecraft/­Revisionable/­Revision.php142
Venturecraft\Revisionable\Revision getValue
…/­vendor/­venturecraft/­revisionable/­src/­Venturecraft/­Revisionable/­Revision.php61
Venturecraft\Revisionable\Revision oldValue
…/­app/­controllers/­admin/­RevisionsController.php20
App\Controllers\Admin\RevisionsController getRevisionJson
<#unknown>0
call_user_func_array
…/­vendor/­laravel/­framework/­src/­Illuminate/­Routing/­Controllers/­Controller.php138
Illuminate\Routing\Controllers\Controller callMethod
…/­vendor/­laravel/­framework/­src/­Illuminate/­Routing/­Controllers/­Controller.php115
Illuminate\Routing\Controllers\Controller callAction
…/­vendor/­laravel/­framework/­src/­Illuminate/­Routing/­Router.php985
Illuminate\Routing{closure}
<#unknown>0
call_user_func_array
…/­vendor/­laravel/­framework/­src/­Illuminate/­Routing/­Route.php80
Illuminate\Routing\Route callCallable
…/­vendor/­laravel/­framework/­src/­Illuminate/­Routing/­Route.php47
Illuminate\Routing\Route run
…/­vendor/­laravel/­framework/­src/­Illuminate/­Routing/­Router.php1016
Illuminate\Routing\Router dispatch
…/­vendor/­laravel/­framework/­src/­Illuminate/­Foundation/­Application.php522
Illuminate\Foundation\Application dispatch
…/­vendor/­laravel/­framework/­src/­Illuminate/­Foundation/­Application.php497
Illuminate\Foundation\Application run
…/­public/­index.php49

[mmodler]

Stop thinking! ;) It was my fault. With accessors i should use getFieldnameAttribute($value) and work with $value, not with $this...

[duellsy]

What is the line of code that is causing the problem?

Revisionable doesn't call any setSomeAttribute() mutators, it only calls the getSomeAttribute() accessor

Your stack trace looks like it's calling the getPriceAttribute accessor, but there's no reference to the setPriceAttribute being called... or am I missing something?

[duellsy]

Ahhh, awesome. All sorted then.