Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

way/database package support #65

Closed
SuperlativeEntity opened this issue Jul 7, 2014 · 6 comments
Closed

way/database package support #65

SuperlativeEntity opened this issue Jul 7, 2014 · 6 comments

Comments

@SuperlativeEntity
Copy link

Possible boot conflict. Need revisionable to gel with way/database (which extends directly from Eloquent)

@duellsy
Copy link
Member

duellsy commented Jul 7, 2014

This is because they are both fighting over the boot method

@duellsy
Copy link
Member

duellsy commented Aug 5, 2014

This will be resolved in v2.0

@duellsy duellsy closed this as completed Aug 5, 2014
@SuperlativeEntity
Copy link
Author

Thanks Man

@GrahamCampbell
Copy link
Contributor

It would be cool if version 2 was php 5.4+ upwards only so we could get rid of the duplication, and just use the trait.

@SuperlativeEntity
Copy link
Author

@GrahamCampbell This worked well for me - watson/validating. It also ignores the current id in terms of validation during an update

@duellsy
Copy link
Member

duellsy commented Aug 9, 2014

@GrahamCampbell oh it will be, that's a definite!
It will also require illuminate/support >= 4.2.6, so we can use:

bootRevisionableTrait() instead of overriding boot()

https://github.com/laravel/framework/blob/master/src/Illuminate/Database/Eloquent/Model.php#L305

(at least, I think that's when this came available)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants