Use getDirty instead of trying to find dirty data manually

[duellsy]

Eloquent offers a method getDirty(), this can be used instead of doing the whole before / after comparison stuff

[Antonimo]

looks like you still trying to do it manually together with the dirty method.
even the core only uses dirty:

$this->setKeysForSaveQuery($query)->update($dirty);

https://github.com/laravel/framework/blob/2680f371eed4b0d6d26818aee0e1eaff79892b96/src/Illuminate/Database/Eloquent/Model.php#L1345

[duellsy]

Not sure where you're referring to?

The changedRevisionableFields() method uses the getDirty() method, and checks that the updated item is indeed something that the owner wants tracked.

https://github.com/VentureCraft/revisionable/blob/master/src/Venturecraft/Revisionable/Revisionable.php#L164

[Antonimo]

i'm referring bough to beforesave and changedRevisionableFields()
where you use $this->originalData and $this->updatedData.
I think in beforesave maybe you can do only

$this->dirty = $this->getDirty();

[duellsy]

Sure, essentially I wanted to clean the data my way before calling getDirty(), but it could just as easily only use the getDirty() method and do a cleanup on the results of that to create the $this->dirty value. Without wanting to be arrogant, I'm taking an 'if it aint broke, don't fix it' approach to this one.

If you want to make a pull request though, go for it and I'll merge it in.

[Antonimo]

i'm taking the same approach for now =) maybe later if I have time Ill make
a pull request

2014-02-24 23:37 GMT+02:00 Chris Duell notifications@github.com:

Sure, essentially I wanted to clean the data my way before calling
getDirty(), but it could just as easily only use the getDirty() method
and do a cleanup on the results of that to create the $this->dirty value.
Without wanting to be arrogant, I'm taking an 'if it aint broke, don't fix
it' approach to this one.

If you want to make a pull request though, go for it and I'll merge it in.

Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-35942182
.

[duellsy]

Cool. There's also just recently been quite a few updates to the whole section for #36

[mnfgul]

@duellsy Hi,

While making update, getDirty returns empty in my case. Details are as follow;

• I am using trait in my model
• Updating the model using;
  MyModel::whereId(1)->first()->update(['field' => 'value']).
• This was not creating revisions. I digged into code and found that get $this->dirtyData = $this->getDirty(); return empty array.

Can you help about this issue.

Thanks.

[mnfgul]

I found my answer. The reason was that getDirty() does not return changes in case of mass updates.

• Model::update([]) does not work
• $model->attribute = 'value'; $model->save(); works.