Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default configs from CT release #16

Closed
lafriks opened this issue Jan 23, 2024 · 2 comments · Fixed by #17
Closed

Provide default configs from CT release #16

lafriks opened this issue Jan 23, 2024 · 2 comments · Fixed by #17

Comments

@lafriks
Copy link

lafriks commented Jan 23, 2024

Currently from release archive only ct binary is extracted but not contents of /etc/ct folder thus breaking upgrades from 1.0.1 and forcing to needlessly add CT lint configuration to every repository. As per docs CT will look for these files in /etc/ct if not specified in command line but currently if not specified it fails with error that files can not be found.

Related to #1
@hajowieland hajowieland mentioned this issue Jan 29, 2024
Merged
@hajowieland
Copy link
Contributor

I just a released version 2.4.0 which includes the default chart-testing configuration files located at /etc/ct.

Would you mind testing it if it now works as expected?

@lafriks
Copy link
Author

lafriks commented Jan 29, 2024

Tested with 2.5.0 and it works great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add chart-testing default config and updated apt packages ventx/helm3-ci
2 participants
@lafriks @hajowieland