Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conformance tests for Ed25519 signatures #171

Open
henrylyons opened this issue Sep 11, 2023 · 3 comments
Open

Add conformance tests for Ed25519 signatures #171

henrylyons opened this issue Sep 11, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed ready-for-pr test-coverage
Milestone

Comments

@henrylyons
Copy link

What is the areas you would like to add the new feature to?

Go-COSE Library

Is your feature request related to a problem?

The project README states that this module supports Ed25519 signatures - however, there are no conformance tests for this. Please add conformance tests for these types of these signatures so that they can use to verify the correctness of the Ed25519 implementation in this module, and modules written in other languages as well (e.g., Rust).

What solution do you propose?

Add positive and negative conformance tests for Ed25519 signatures, covering signature creation and verification functionality.

What alternatives have you considered?

I can create separate Ed25519 conformance tests for my COSE implementation, but I prefer to have a common set of tests that can be used to test COSE implementations in different languages.

Any additional context?

No response

@henrylyons henrylyons added the enhancement New feature or request label Sep 11, 2023
@OR13
Copy link
Collaborator

OR13 commented Oct 6, 2023

https://datatracker.ietf.org/doc/html/rfc8152#section-8.2

Not sure if there are test vectors that we can import, but we should start by finding and linking them.

@SteveLasker SteveLasker added this to the v1.2.0 milestone Oct 6, 2023
@SteveLasker SteveLasker added the help wanted Extra attention is needed label Oct 6, 2023
@OR13
Copy link
Collaborator

OR13 commented Oct 6, 2023

Blocked pending: gluecose/test-vectors#15

@SteveLasker SteveLasker added the blocked blocked for action: see notes which should explain the status label Oct 6, 2023
@OR13
Copy link
Collaborator

OR13 commented Oct 9, 2023

Unblocked I think, see: gluecose/test-vectors#15 (comment)

@OR13 OR13 added ready-for-pr and removed blocked blocked for action: see notes which should explain the status labels Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed ready-for-pr test-coverage
Projects
None yet
Development

No branches or pull requests

3 participants