Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CWT Claims in Headers #173

Open
OR13 opened this issue Sep 12, 2023 · 6 comments · May be fixed by #183
Open

Support for CWT Claims in Headers #173

OR13 opened this issue Sep 12, 2023 · 6 comments · May be fixed by #183
Assignees
Labels
blocked blocked for action: see notes which should explain the status enhancement New feature or request
Milestone

Comments

@OR13
Copy link
Collaborator

OR13 commented Sep 12, 2023

What is the areas you would like to add the new feature to?

Go-COSE Library

Is your feature request related to a problem?

See https://datatracker.ietf.org/doc/draft-ietf-cose-cwt-claims-in-headers/

What solution do you propose?

See https://datatracker.ietf.org/doc/draft-ietf-cose-cwt-claims-in-headers/

What alternatives have you considered?

None.

Any additional context?

Once this document becomes an RFC it is advisable to add support for it to protected headers.

@OR13 OR13 added the enhancement New feature or request label Sep 12, 2023
@SteveLasker SteveLasker added the blocked blocked for action: see notes which should explain the status label Oct 6, 2023
@SteveLasker
Copy link
Contributor

Blocked (labeled) pending the RFC

@SteveLasker SteveLasker added this to the Future milestone Oct 6, 2023
@OR13
Copy link
Collaborator Author

OR13 commented Dec 1, 2023

its still progressing, the code points have changed.

its also debatable if this should be done in this repo, will there be a go-cwt ?

@OR13
Copy link
Collaborator Author

OR13 commented Dec 1, 2023

@thomas-fossati @qmuntal do you think we should do all the CWT stuff in a seperate repo? if so, this issue should probably be closed.

@thomas-fossati
Copy link
Contributor

@thomas-fossati @qmuntal do you think we should do all the CWT stuff in a seperate repo?

hi @OR13! I've just glanced through the draft and, unless I'm mistaken, there is no special processing that needs to happen at the COSE layer. So, apart from adding the registered "CWT Claims" code-point into the consts list in headers.go, I don't see any other actions for go-cose.

if so, this issue should probably be closed.

We can keep this open until the IANA registration has completed, at which point we add the const and close it.

@SteveLasker
Copy link
Contributor

@OR13 agreed to initiate a PR for review.

@SteveLasker SteveLasker modified the milestones: Future, v1.3.0 Jan 26, 2024
@OR13 OR13 linked a pull request Jan 26, 2024 that will close this issue
@OR13
Copy link
Collaborator Author

OR13 commented Jan 26, 2024

PR is up here: #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked blocked for action: see notes which should explain the status enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants