Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recaptcha Entreprise integration has a new config field breaking existing integrations #1896

Closed
uandco opened this issue May 21, 2024 · 2 comments

Comments

@uandco
Copy link

uandco commented May 21, 2024

Describe the bug

The older versions of Formie used to have a reCAPTCHA Site Key and reCAPTCHA Secret Key fields to configure ReCaptcha Entreprise.

Now there's a new Google Console API Key field which needs to be populated when updating the plugin, otherwise existing reCaptcha integrations break as they don't send the key anymore (which was taken from the reCAPTCHA Secret Key field), resulting in a 403 from the ReCaptcha API when submitting a form.

I used to use the API key in the reCAPTCHA Secret Key field. It turns out using the same value for reCAPTCHA Secret Key and Google Console API Key is the only way to configure the integration now, as reCAPTCHA Secret Key is mandatory but shouldn't even exist for ReCaptcha Entreprise, as it's only relevant for v3.

Steps to reproduce

See above

Form settings

  • Multi-page form: N/A
  • Submission Method: N/A
  • Client-side Validation: N/A
  • Custom Form Templates: N/A

Craft CMS version

Craft Pro 4.9.4

Plugin version

2.1.15

Multi-site?

No

Additional context

Imho, reCAPTCHA Secret Key should have been renamed to Google Console API Key, but still use the old config name, or a proper migration needs to be in place.

The fact reCAPTCHA Secret Key also remains is confusing as there's no secret in ReCaptcha Entreprise.

@engram-design
Copy link
Member

Fixed for the next release. To get this early, run composer require verbb/formie:"dev-craft-4 as 2.1.15". This will handle using the API Key setting or not. It's now been removed and we're back to the "Secret Key", although it's been visually renamed.

As for removing "reCAPTCHA Secret Key" or even renaming it - the reason that hasn't been done is due to the limitation of how Craft's toggle-field behaviour works. For now, I'm just doing something manual to change the label for clarity.

@engram-design
Copy link
Member

Fixed in 2.1.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants