Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to "Save as New Form" #4

Closed
engram-design opened this issue Jul 21, 2020 · 7 comments
Closed

Unable to "Save as New Form" #4

engram-design opened this issue Jul 21, 2020 · 7 comments
Labels

Comments

@engram-design
Copy link
Member

Clicking "Save as New Form" doesn't do anything for a form. It should duplicate the form.

@shoored
Copy link

shoored commented Jul 21, 2021

I just tried this feature, but the save button loading icon keeps spinning and nothing happens.
Then I noticed the same thing happens when just saving an existing form.

Not sure if I borked it or this is another bug.

In the logfiles I see
2021-07-21 17:42:21 [-][15689][-][info][formie] Setting unknown property: verbb\formie\fields\formfields\Heading::columnSuffix /home/******/vendor/yiisoft/yii2/base/Component.php:210 2021-07-21 17:42:21 [-][15689][-][info][application] $_GET = []

@engram-design
Copy link
Member Author

engram-design commented Jul 24, 2021

Pretty sure this is a Craft 3.7 bug. Can you confirm you're on 1.4.10? If you've created any new fields on Craft 3.7 without updating first, you'll get this error. Saving the form multiple times should fix the issue until you update.

@shoored
Copy link

shoored commented Jul 26, 2021

@engram-design I'm still on the latest 3.6 Craft (waiting for the first bugs to flatten out) but indeed Formie 1.4.10. Just updated to 1.4.11, removed the Heading fields (they were always there) but still the same thing.

@engram-design
Copy link
Member Author

Ah, yes this might be an issue on Craft 3.6, although I'm guarding against it - looks like I've missed one instance of it.

If you can try out the latest version, change your verbb/formie requirement in composer.json to:

"require": {
  "verbb/formie": "dev-craft-3 as 1.4.11",
  "...": "..."
}

Then run composer update.

@shoored
Copy link

shoored commented Jul 26, 2021

Thanks for the quick reply! This is what I get when viewing a form in the CP:

ParseError
syntax error, unexpected '$schemaVersion' (T_VARIABLE)

    1. in /Users/sjoerd/dev/****/vendor/verbb/formie/src/services/Forms.php at line 505
    496497498499500501502503504505506507508509510511512513514

                            'handle' => $fieldData['handle'] ?? null,
                            'rowId' => $fieldData['rowId'] ?? null,
                            'rowIndex' => $rowIndex,
                            'columnWidth' => $columnWidth,
                            'settings' => $settings,
                            'required' => (bool)$required,
                        ]
     
                        // TODO: remove schema version condition after next beakpoint
                        $schemaVersion = Craft::$app->getInstalledSchemaVersion();
                        ```

@engram-design
Copy link
Member Author

@shoored Sorry, I pushed that blindly without checking properly. If you can composer update again?

@shoored
Copy link

shoored commented Jul 27, 2021

@engram-design No problem, this update is working! Both saving a form and duplicating one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants