Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a better handler for the auth IPs #24

Open
jesuismaxime opened this issue Jun 29, 2020 · 3 comments
Open

Need a better handler for the auth IPs #24

jesuismaxime opened this issue Jun 29, 2020 · 3 comments

Comments

@jesuismaxime
Copy link

It would be better if the plugin uses the database to store the IPs or at least merge the list from the patrol.php file with one from the project.yaml. The fact that only one of them is working is an issue when working with multiple environment. I juste wiped out my production IPs list because my local environment doesn’t have all the production auth IPs.

This will also allow changes in production when the Craft setting allowAdminChanges is net to false. For now it display a system error because the plugin isn’t able to push changes to the yaml file.

@engram-design
Copy link
Member

Agreed. Not quite sure what the thinking was for re-saving plugin settings but that won't work at all on environments with allowAdminChanges = false.

@jesuismaxime
Copy link
Author

Any update regarding this? Really need to have Patrol activated on staging/production environments where admin changes are not allowed.

@engram-design
Copy link
Member

No update yet, sorry - but it'll take a little bit to get that sorted, and backwards-compatible.

Planning this to only be available for Craft 4 though, if that factors in on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants