Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete wishlist item when owner element is deleted #121

Closed
engram-design opened this issue Feb 5, 2023 · 1 comment
Closed

Delete wishlist item when owner element is deleted #121

engram-design opened this issue Feb 5, 2023 · 1 comment

Comments

@engram-design
Copy link
Member

engram-design commented Feb 5, 2023

Many people expect the wishlist item to be deleted if the owner element is also deleted. This probably makes sense - if the user has added an entry/element to their wishlist, and that "thing" no longer exists, it's meaningless to keep it in your list.

However, it's a bit of a feature that the wishlist item doesn't get deleted. This is to allow developers to handle deleted elements. For example, the user might head back to their list and notice one thing they've added is suddenly missing. This confuses the user if there's no note saying "this thing was deleted/removed/no longer available". Suddenly just removing something isn't good UX in my opinion.

As such, it's currently up to developers to check if item.getOwner().

So maybe this should be configurable?

@engram-design engram-design added this to the 3.0 milestone Dec 4, 2023
@engram-design
Copy link
Member Author

Added in 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant