Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose public methods like "getInUserLists" in WishlistVariable.php as services #127

Closed
Antimated opened this issue Jun 15, 2023 · 2 comments
Closed

Expose public methods like "getInUserLists" in WishlistVariable.php as services #127

Antimated opened this issue Jun 15, 2023 · 2 comments
Labels
beta feature request
Milestone
3.0

Comments

@Antimated
Copy link

Antimated commented Jun 15, 2023 •
edited

What are you trying to do?

We want to use the functionality of the getInUserLists twig variable but we need this data in our own module. Now we have to basically copy this method in our own service so we can expose it to the rest of our project.

What's your proposed solution?

Copy the logic of the public methods in WishlistVariable.php to a service so we can use these services in our own modules 😄!

Additional context

No response
@engram-design engram-design added this to the 3.0 milestone Jun 16, 2023
@engram-design
Copy link
Member

Pencilling in as part of a larger refactor

@engram-design
Copy link
Member

Added in 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta feature request
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@engram-design @Antimated