Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transparently support pre-configured binaries #25

Merged
merged 1 commit into from Apr 25, 2021
Merged

feat: Transparently support pre-configured binaries #25

merged 1 commit into from Apr 25, 2021

Conversation

connec
Copy link
Contributor

@connec connec commented Jun 14, 2020

In the event that a binary is already defined for the target entrypoint in Cargo.toml, the associated name is used without rewriting the Cargo.toml file. This approach may be preferable with some development environments that require binaries to be defined in order to perform builds, etc.

@mike-engel
Copy link
Collaborator

Hi @connec would you mind rebasing this?

@connec
Copy link
Contributor Author

connec commented Mar 27, 2021

Hi @mike-engel, very long overdue but I've rebased this now! I also added a test, which like all the tests fails on master, but it works when combined with #38.

In the event that a binary is already defined in Cargo.toml for the
target entrypoint the associated name is used without rewriting the
Cargo.toml file. This approach may be preferable with some development
environments that require binaries to be defined in order to perform
builds, etc.
@connec
Copy link
Contributor Author

connec commented Apr 6, 2021

I realised entrypointPath must have become absolute at some point, so I've updated this to deal with that.

@mike-engel
Copy link
Collaborator

Thanks for your patience here @connec!

@mike-engel mike-engel merged commit d667d83 into vercel-community:master Apr 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants