Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to use vercel dev #38

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

de-luca
Copy link
Contributor

@de-luca de-luca commented Mar 7, 2021

Hi!

As evoked in #31, the tests seamed outdated.
I refactored them into using vercel dev.

This mainly remove the publication requirement.
However it seems like vercel dev cannot be used without linking to a project (see vercel/vercel#4925).

I kept what was beeing tested and only changed the way around.

This can also run on GitHub Actions, although it would require a vercel token.
(This can be seen here: https://github.com/de-luca/now-rust/actions?query=branch%3Agh)

Copy link
Collaborator

@mike-engel mike-engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@de-luca Thanks for this, and sorry for the delay. One comment, and could you rebase this with the latest master? Thanks!

@@ -0,0 +1,9 @@
[package]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file can probably be deleted, no? Or is there a reason a file with a .backup extension is included?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch it was leftover from my tests.

@de-luca de-luca force-pushed the tests branch 2 times, most recently from 5cacf43 to 81c04db Compare May 9, 2021 13:56
@de-luca
Copy link
Contributor Author

de-luca commented May 9, 2021

I rebased the branch and cleaned the leftover (I hope I didn't took too long).
Tests are passing with #25 additions.

@mike-engel
Copy link
Collaborator

Hi @de-luca, no worries at all! I've been busy as well. It looks like there's one last remaining conflict in the package-log.json file. When you have time to take a look at that, I think this looks good to merge thereafter.

@mike-engel mike-engel merged commit 6dd0316 into vercel-community:master Jun 13, 2021
@mike-engel
Copy link
Collaborator

Thanks for this @de-luca and for your patience 😄

@de-luca de-luca deleted the tests branch June 14, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants