Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider porting to JavaScript #34

Closed
lukebennett88 opened this issue Oct 28, 2020 · 3 comments
Closed

Consider porting to JavaScript #34

lukebennett88 opened this issue Oct 28, 2020 · 3 comments

Comments

@lukebennett88
Copy link

Learning TypeScript is a large barrier to entry for a lot of developers (myself included).

This project seems like a great example of best practices for a Next.js/e-commerce site (I was planning to use it as the basis for a headless Shopify store as someone coming from Gatsby) I think it would be useful to a lot more people if it was in JavaScript rather than TypeScript.

@dougwithseismic
Copy link

+1 it's a great project skeleton but there's actually very little that actually needs TS here.

@okbel
Copy link
Contributor

okbel commented Oct 28, 2020

Interesting. Let's elaborate here.

There's two sides of the coin here. We can remove TypeScript but we'll have to add a lot of helpers/handlers because of the risk of a dynamic and not statically typed language (JavaScript).

When building products at scale, you can't always 👮‍♀️ everyone to use Components well and to -not-add- technical debt. TS types are incredibly helpful in that realm. You can specify function needs, declare structure, etc.

Also, enforcing the usage of types allow us and you to build better products. I highly encourage you to give it a try.

@okbel
Copy link
Contributor

okbel commented Oct 28, 2020

Closing this for now, but open to reconsider keeping a branch updated just in JS.

@okbel okbel closed this as completed Oct 28, 2020
persi123 pushed a commit to persi123/commerce that referenced this issue Oct 21, 2021
[CHEC-578] - Hero content and images edit
Wkasel pushed a commit to DSCO-Co/poochie that referenced this issue Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants