Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie Pop-Up not properly disappearing #53

Closed
nico-bachner opened this issue Oct 30, 2020 · 4 comments
Closed

Cookie Pop-Up not properly disappearing #53

nico-bachner opened this issue Oct 30, 2020 · 4 comments

Comments

@nico-bachner
Copy link
Contributor

nico-bachner commented Oct 30, 2020

The Accept/Reject Cookies prompt doesn't completely disappear from the page when clicked, but rather gets pushed below the bottom of the page. Generally, this would essentially make it invisible, but when scrolling against the bottom, the bounce effect of the browser reveals the prompt

Fix suggestions:

  1. Add opacity fade to onclick transition (probably the better option)
  2. Setting global CSS overscroll-behavior to none

I've been wanting to fix this myself, but I can't seem to find the cookie pop-up component

@nico-bachner nico-bachner changed the title Cookie Toast not properly disappearing Cookie Pop-Up not properly disappearing Oct 30, 2020
@marbiano
Copy link
Contributor

@nico-bachner #52

@marbiano
Copy link
Contributor

I'll take a look at the styling part since I'm there :)

@nico-bachner
Copy link
Contributor Author

Perfect. Thank you!

@okbel
Copy link
Contributor

okbel commented Nov 2, 2020

PR Coming! Thank you!

@okbel okbel closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants