Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

It creates a new agent on every redirect #23

Closed
matheuss opened this issue Jun 22, 2018 · 2 comments
Closed

It creates a new agent on every redirect #23

matheuss opened this issue Jun 22, 2018 · 2 comments
Assignees
@matheuss
Labels
bug

Comments

@matheuss
Copy link
Member

https://github.com/zeit/fetch/blob/53ee6c5bf02a5dd261a6ce4df0f687fa32c2b4d1/index.js#L57-L59

It should only create one agent per protocol.
@matheuss matheuss added the bug label Jun 22, 2018
@matheuss matheuss self-assigned this Jun 22, 2018
@MunifTanjim
Copy link

MunifTanjim commented Oct 14, 2018 •
edited

Doesn't actually create new agent. getAgent return previously created agent if available.

https://github.com/zeit/fetch/blob/c04c28a6468ec216932d9aef9f312a2692aa42d4/index.js#L16-L35

But if custom agent is passed, it is overridden: #25 (comment)

@Ethan-Arrowood
Copy link
Collaborator

Thank you for the report. We are archiving this project; you can read more details here: #83

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matheuss matheuss

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matheuss @MunifTanjim @Ethan-Arrowood