Skip to content
This repository has been archived by the owner on Nov 9, 2023. It is now read-only.

Should the types be moved to dev dependencies? #52

Closed
giraffesyo opened this issue Feb 6, 2021 · 1 comment
Closed

Should the types be moved to dev dependencies? #52

giraffesyo opened this issue Feb 6, 2021 · 1 comment

Comments

@giraffesyo
Copy link

If the package is used in a javascript project, a warning is thrown:

warning " > @vercel/fetch@6.1.0" has unmet peer dependency "@types/node-fetch@2".

If this was moved to dev dependencies, it would stop that error from showing up I believe. Also, we could probably move @types/async-retry down to dev dependencies too while we're at it.

Would there be any problems I'm not foreseeing if I made this change?

@Ethan-Arrowood
Copy link
Collaborator

Thank you for the report. We are archiving this project; you can read more details here: #83

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants