Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is "burnt" into background #1008

Closed
2 tasks done
TraceyK14 opened this issue Nov 16, 2016 · 24 comments
Closed
2 tasks done

Text is "burnt" into background #1008

TraceyK14 opened this issue Nov 16, 2016 · 24 comments

Comments

@TraceyK14
Copy link

TraceyK14 commented Nov 16, 2016

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

When you lose focus on Hyper window and then return focus the text will become "burnt" into the background. The effect is removed if you lose focus and then apply focus to window again.

You can view the text by typing clear into the terminal and hitting enter.

Also can be done by reaching the end of the terminal window and continue to press enter causing the window to scroll

Hyper's default theme with the exception of the opacity change to view the "burnt" effect.
2016-11-16_13-44-28

My normal terminal theme.
2016-11-16_13-26-29

@rauchg
Copy link
Member

rauchg commented Nov 16, 2016

Are you using transparency?

@TraceyK14
Copy link
Author

TraceyK14 commented Nov 17, 2016

Yes the opacity on the background is half in the images provided.
// terminal background color backgroundColor: 'rgba(0,0,0,.5)',

But it does not have to be half, I can see it at 0.8 as well, it's just easier to see at 0.5 which is what my theme is set to.

@rauchg
Copy link
Member

rauchg commented Nov 17, 2016

Yep so the reason I introduced opacity was "optimistic". There are some Electron issues still with transparency :(

@rauchg
Copy link
Member

rauchg commented Nov 17, 2016

And by Electron I potentially mean Chromium as well

@TraceyK14
Copy link
Author

Yea there was some discussion of it being a potential Electron issue on the slack channel. Do you still want to keep this ticket open until it is resolved on their end? (no telling when or if it will be)

@ppot
Copy link
Contributor

ppot commented Nov 17, 2016

@rauchg The macOS transparency has been natively added to electron recently

@rauchg
Copy link
Member

rauchg commented Nov 17, 2016

So, have we tried reproducing this with Hyper + latest electron? Thanks for letting me know

@ppot
Copy link
Contributor

ppot commented Nov 17, 2016

@rauchg No, It was talked today in slack see PR from electron
electron/electron#7898

@timothyis
Copy link
Contributor

@ppot Vibrancy is not just transparency, right? I think Electron has had transparency for a while with frameless windows like Hyper.app is.

@ppot
Copy link
Contributor

ppot commented Nov 19, 2016

@codetheory Good question, I can't tell!

@timothyis
Copy link
Contributor

I believe that's the case. In which case, Electron version shouldn't matter.

@andydude
Copy link

andydude commented Dec 1, 2016

I'm on Mac OS X 10.10.5 Yosemite, and I have a similar issue, but it might be related to this issue, or the Windows transparency issue, but I'm not sure how to classify it, or even describe it.
screen shot 2016-11-30 at 9 31 47 pm
This first one was after maximizing (the new fullscreen) a window, then minimizing it again.
screen shot 2016-11-30 at 9 32 19 pm
The second one was opening a new window, then opening a dozen tabs. Notice the time is overwriting the previous time in my prompt.

@ppot
Copy link
Contributor

ppot commented Dec 1, 2016

@andydude What version you have. Since you have the path_helper in you're header it might be related to your version. Did you try the lastest master?

@andydude
Copy link

andydude commented Dec 1, 2016

Yes, I just tried master, and I have the same issue.
screen shot 2016-12-01 at 3 08 17 pm
screen shot 2016-12-01 at 3 08 00 pm

@wmertens
Copy link

If it's any help, this reminds me of an issue Terminal.app had, where if you selected a text shadow with a transparent background, the shadows would stick around when the text moved. AFAICT they "solved" it by removing the text shadow option :)

@iam4x
Copy link

iam4x commented Apr 14, 2017

I have this issue on my MacbookPro Retina 13" touchbar with Sierra last version, but it's not happening with my Hackintosh with a nVidia 980GTX. It might be hardware/graphics/driver related?

@bsmith-cycorp
Copy link

I'm experiencing this on my Mid 2014 Retina Macbook Pro 15", with Intel Iris Pro 1536 MB graphics. I too have a partly transparent background color, set in the regular config file.

I haven't looked at the code, but perhaps the terminal is getting cleared by "painting" the background color over the existing text? That would cause the text to only get partially faded out if the background is semitransparent, which is exactly the behavior I'm seeing.

@chabou
Copy link
Collaborator

chabou commented Apr 18, 2017

Seems duplicate #808

@Stanzilla Stanzilla mentioned this issue Jan 23, 2018
8 tasks
@albinekb
Copy link
Contributor

Fixed in v2 🎉

@trueter
Copy link

trueter commented Apr 19, 2018

@albinekb Great news! I'm curious about the nature of the problem. Is there a commit you can reference that specifically addresses this?

@albinekb
Copy link
Contributor

No @trueter, we have worked during almost a year to switch the terminal rendering library from hterm (DOM-based) to xterm (Canvas based), and by doing that, this is no longer an issue 👍 Xterm is maintained by Microsoft and used by both VS Code (electron) and Visual Studio (internet explorer webview), so sadly it's not fixed by one change but rather just a bonus of the more mature and better maintained xterm library 🥇

@ajcrites
Copy link

This is still happening for me with Hyper v2 on OS X. It will happen if I move the Hyper window to another screen, or if I do something like close and open my laptop.

@joeyg-stripe
Copy link

I think I have the same problem as ajcrites

@Coder1221
Copy link

having the same issue .
how to resolve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests