Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key repeat in hyper canary #2297

Closed
1 of 2 tasks
pablopunk opened this issue Sep 27, 2017 · 8 comments
Closed
1 of 2 tasks

Key repeat in hyper canary #2297

pablopunk opened this issue Sep 27, 2017 · 8 comments
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🐛 Type: Bug Issue pertains to something wrong within Hyper v2

Comments

@pablopunk
Copy link
Contributor

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: MacOS 12.13 High Sierra
  • Hyper.app version: 2.0.4
  • Link of a Gist with the contents of your .hyper.js: https://gist.github.com/pablopunk/5af1eb66a0ecd9833a252a63d38c3547
  • Relevant information from devtools (CMD+ALT+I on Mac OS, CTRL+SHIFT+I elsewhere): N/A
  • The issue is reproducible in vanilla Hyper.app: Canary straight out of the box

Issue

Basically pressing and holding any letter won't repeat it. Like, I press and hold k and it prints just one.

Also, if I press and hold space it does repeat this one.

@albinekb albinekb added 🐛 Type: Bug Issue pertains to something wrong within Hyper v2 labels Sep 27, 2017
@albinekb albinekb mentioned this issue Sep 28, 2017
8 tasks
@derrickpelletier
Copy link
Contributor

Issue originates in term.js: xtermjs/xterm.js#265

@albinekb albinekb self-assigned this Nov 14, 2017
@albinekb albinekb added the 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself label Nov 14, 2017
@albinekb
Copy link
Contributor

albinekb commented Nov 14, 2017

This is an upstream issue, so from here let's follow the discussion over at xtermjs/xterm.js#265

Here's a workaround: Disable Apple press and hold for Hyper by pasting this into any terminal:

defaults write co.zeit.hyper ApplePressAndHoldEnabled -bool false

You need to restart Hyper for this to take effect

@jesseleite
Copy link

jesseleite commented Nov 20, 2017

defaults write co.zeit.hyper ApplePressAndHoldEnabled -bool false

Doesn't seem to work for me on 2.1.1 😢

@pablopunk
Copy link
Contributor Author

I fixed it for all apps on my mac:

defaults write NSGlobalDomain ApplePressAndHoldEnabled -bool false

Then reboot and it's done!

@ipatch
Copy link

ipatch commented Dec 21, 2017

@pablopunk thanks for sharing, do you know of any way for the below command to take affect without a reboot?

defaults write NSGlobalDomain ApplePressAndHoldEnabled -bool false

@pablopunk
Copy link
Contributor Author

@ipatch not sure, maybe logout and login, try that.

@SavePointSam
Copy link

looks like xterm recently fixed this problem on their end

@autonome
Copy link

looks like xterm recently fixed this problem on their end

Fixed in 3.10.0 of xterm last December in xtermjs/xterm.js#265

Hyper is on 3.12.0 as of #3536.

But the problem still exists for me in Hyper 2.1.2. Maybe not in stable yet? How can I find that out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🐛 Type: Bug Issue pertains to something wrong within Hyper v2
Projects
None yet
Development

No branches or pull requests

8 participants