Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to enable font ligatures in the 2.0.0 series #2793

Closed
1 of 2 tasks
mapitman opened this issue Mar 30, 2018 · 6 comments
Closed
1 of 2 tasks

Method to enable font ligatures in the 2.0.0 series #2793

mapitman opened this issue Mar 30, 2018 · 6 comments
Labels
🔌 Type: Plugin Request Issue is a plugin request for Hyper

Comments

@mapitman
Copy link
Contributor

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate

Issue

All of the methods I've found for enabling font ligatures do not work in the 2.0.0 series of releases. Is there an example of the correct CSS for 2.0.0?

@chaseleinart
Copy link

@mapitman - Hi Mark - according to comments on #914, hyper does not support ligatures due to current limitations with xterm3. That project still has ligatures as an open feature request according to the link below

@mapitman
Copy link
Contributor Author

Thanks @chaseleinart . I'll go ahead and close this issue then.

@Stanzilla Stanzilla added the 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself label Apr 23, 2018
@mainrs
Copy link

mainrs commented Aug 26, 2018

Looks like they published an official addon to enable font ligatures support: https://github.com/xtermjs/xterm-addon-ligatures

@BenMcH
Copy link

BenMcH commented Sep 6, 2018

@sirwindfield Great catch! I just built hyper locally with that addon. I had to precompile the library (because it's typescript) and I ended up throwing it in the lib directory, but I was able to get ligatures working.

If I can figure out a better way to include this change and get it building, I'll submit a PR!

@mapitman We may want to reopen this now that it's been shown to work with the addon from xterm.

@albinekb
Copy link
Contributor

albinekb commented Sep 7, 2018

@BenMcH you can use https://www.npmjs.com/package/hyper-font-ligatures which adds the xterm plugin for you 🎉

Installation

Using the built-in Hyper plugin manager

$ hyper i hyper-font-ligatures

Using the .hyper.js file

Open the ~/.hyper.js file using your favorite text editor and edit the
plugins array to include hyper-font-ligatures:

plugins: ['hyper-font-ligatures'],

In both cases, a 'Full Reload' (View -> Full Reload) is required.

@albinekb albinekb added 🔌 Type: Plugin Request Issue is a plugin request for Hyper and removed 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself labels Sep 7, 2018
@Tyriar
Copy link
Contributor

Tyriar commented Sep 14, 2018

Keep in mind this is very much in the early stages as it's using a beta build of the ligatures addon. We're still finalized on the API exposed in xterm.js, which means this might break at one point (and need xterm-addon-ligatures updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔌 Type: Plugin Request Issue is a plugin request for Hyper
Projects
None yet
Development

No branches or pull requests

7 participants