Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-app update notification notes link is 404ing #3313

Open
2 tasks done
parktheredcar opened this issue Dec 7, 2018 · 2 comments
Open
2 tasks done

In-app update notification notes link is 404ing #3313

parktheredcar opened this issue Dec 7, 2018 · 2 comments

Comments

@parktheredcar
Copy link
Contributor

parktheredcar commented Dec 7, 2018 •
edited
Loading

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: Windows 10 latest
  • Hyper.app version: 2.1.0 canary2

In-app notficaiton notes link isn't being generated correctly. Latest pop-up linked to the this:
https://github.com/zeit/hyper/releases/tag/2.1.0-canary3

Should have linked to this

https://github.com/zeit/hyper/releases/tag/2.1.0-canary.3

dot between canary and 3 appears to be missing.

#2636 and #2637 will probably lead to the place the dot is being dropped
@parktheredcar
Copy link
Contributor Author

Still active as of 2.1.0-canary4

@rossng
Copy link

rossng commented Jan 6, 2019

Same issue with 3.0.0-canary2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@parktheredcar @rossng