Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lastest win home & end bindings #3378

Closed
2 tasks done
andrzejnovak opened this issue Jan 2, 2019 · 4 comments
Closed
2 tasks done

Fix lastest win home & end bindings #3378

andrzejnovak opened this issue Jan 2, 2019 · 4 comments

Comments

@andrzejnovak
Copy link

andrzejnovak commented Jan 2, 2019

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • WIN, 18298:
  • 3.0.1
  • Is Vanilla:

Issue

Key bindings for beginning and end of line no longer work as defaults.
https://github.com/zeit/hyper/blob/master/app/keymaps/win32.json#L44-45

Can be fixed by as:
"editor:moveBeginningLine": "Home",
"editor:moveEndLine": "End",

@benc-uk
Copy link

benc-uk commented Jan 24, 2019

Why was this changed?!
Glad I found this, it was driving me mad

@juancampa
Copy link
Contributor

Not sure I understand (I'm on Linux so I can't test it). The defaults you linked are broken? and then you fix them by adding those to your ~/.hyper.js?

Also, what version are you on? There's no 3.0.1, you mean 3.0.0-canary.* or 2.0.1?

@andrzejnovak
Copy link
Author

The defaults you linked are broken? and then you fix them by adding those to your ~/.hyper.js

Correct.
I'm on 3.0.0-canary.5, sorry about that. I expect this was related to the win console changes, the defaults have just not been updated.

@vosdev
Copy link
Contributor

vosdev commented Mar 9, 2019

Could we please fix this simple typo? It is driving me crazy :-)

I have tested and can confirm that this does not work:

"editor:moveBeginningLine": "home",
"editor:moveEndLine": "end",

and this does work:

"editor:moveBeginningLine": "Home",
"editor:moveEndLine": "End",

I am running 3.0.0-canary.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants