Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babel/webpack modules missing from package.json #35

Closed
Tyriar opened this issue Jul 4, 2016 · 5 comments
Closed

Babel/webpack modules missing from package.json #35

Tyriar opened this issue Jul 4, 2016 · 5 comments

Comments

@Tyriar
Copy link
Contributor

Tyriar commented Jul 4, 2016

Trying to build locally (on Linux) I hit:

ERROR in Entry module not found: Error: Cannot resolve module 'babel-loader' in /home/daniel/dev/hyperterm/app

Installing that then asks for babel-core, installing that leads to an Unknown plugin "transform-react-jsx" error. An webpack watch entry in package.json scripts would be good in addition to more complete devDependencies.

@montogeek
Copy link
Contributor

montogeek commented Jul 4, 2016

I just did a clean installation and everything work as expected, maybe npm failed, please try again :)

@rauchg rauchg closed this as completed Jul 4, 2016
@rauchg
Copy link
Member

rauchg commented Jul 4, 2016

All the missing modules you mention are indeed there. I think @montogeek is right!

@Tyriar
Copy link
Contributor Author

Tyriar commented Jul 4, 2016

Doesn't this need to mention babel?

  "dependencies": {
    "child_pty": "3.0.1",
    "default-shell": "1.0.1",
    "electron-is-dev": "0.1.1",
    "electron-packager": "7.1.0",
    "electron-prebuilt": "1.2.5",
    "uid2": "0.0.3"
  },
  "devDependencies": {
    "eslint": "2.13.1",
    "eslint-config-standard": "5.3.1",
    "eslint-plugin-promise": "1.3.2",
    "eslint-plugin-standard": "1.3.2"
  },

@montogeek
Copy link
Contributor

montogeek commented Jul 4, 2016

@Tyriar The package.json in the main directory is for the Electron app itself, the package.json inside the app directory is the one used to transpile the app source code.

Please try to run ./install.sh first in the main directory, then move to the app directory and run npm i, it should install all dependencies :)

@Tyriar
Copy link
Contributor Author

Tyriar commented Jul 4, 2016

Oh that's the issue, why not just have a single package.json though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants