True colors support

[pablopunk]

https://github.com/xtermjs/xterm.js/releases/tag/3.13.0

[Tyriar]

There were big changes in this release that would break the webgl renderer. I've updated for the most part the webgl renderer but the custom patches on top of it (and for the emoji input) would likely need to be redone, also true color doesn't work on it yet.

[pablopunk]

@Tyriar you're right, I tried to merge 3.13.0 tag and I get those conflicts. Is there a reason to have a fork with the patches instead of making a PR to xterm directly? Just curious

[Tyriar]

@pablopunk there are 2 PRs out on xterm that aren't finished yet xtermjs/xterm.js#1890, Tyriar/xterm.js#5. Also the webgl renderer isn't merged in yet so it may fall behind (I work on xterm not hyper).

[pablopunk]

@Tyriar Ok, thanks for the info 🙂. I'll keep this issue open til we get true colors then, I'll update the title

[pablopunk]

In case anybody wants to have true colors in the meantime, I built hyper for Mac with the new xterm. You can download it here, but keep in mind you'll need to disable WebGL inside your .hyper.js and also you won't get emoji support.

[pablopunk]

@Tyriar I'm guessing hyper could migrate once these are completed?

[Tyriar]

@pablopunk I think the plan for Hyper is to wait for v4 yes, true color won't work in the webgl renderer until xtermjs/xterm.js#2249 is done though.

[SkyaTura]

@Stanzilla I understand closing #2294 due to duplicity, however, this issue isn't solved yet.

As you suggested on the referenced issue, I tested on latest Canary build and still doesn't work.

Should I open another issue as you mentioned there or this can be used? Or True Colors won't be officially supported?

[Stanzilla]

@SkyaTura it should work in the latest CI build from canary, can you test it there please?

[SkyaTura]

Sorry for my ignorance @Stanzilla, but I didn't found the build you've mentioned anywhere.
However, I've cloned the most recent commit and built myself and worked fine.

You can close it now, again, sorry for reopening it.

My emojis are gone, tho

[Stanzilla]

Yay!