Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.18 -> 0.4.1 is a major change #127

Closed
leo opened this issue Dec 6, 2018 · 4 comments
Closed

0.1.18 -> 0.4.1 is a major change #127

leo opened this issue Dec 6, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@leo
Copy link

leo commented Dec 6, 2018

This error kept showing for npm install -g now@canary for Now CLI:

image

This is because the download script is run through ncc.

Downgrading fixed it. In turn, it seems like one of the releases in between should've been a major one.

@leo leo added the bug Something isn't working label Dec 6, 2018
@rauchg
Copy link
Member

rauchg commented Dec 6, 2018

I think it's more of a bug, not a "major change" in terms of semver. @leo can you point us to:

  • the source file on GitHub
  • the ncc build instruction on GitHub
  • ideally, the generated output

@leo
Copy link
Author

leo commented Dec 6, 2018

You can test this by running npm install -g now@13.0.0-canary.18.

@leo
Copy link
Author

leo commented Dec 6, 2018

More details:

@leo
Copy link
Author

leo commented Dec 7, 2018

Resolved!

@leo leo closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants