feat: support customEmit ncc option #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
custom-emit
branch
from
b4a44ff
to
0bb389b
Compare
4 tasks
guybedford
force-pushed
the
custom-emit
branch
from
9cd0e20
to
494f7fa
Compare
styfle
reviewed
Jan 10, 2021
styfle
reviewed
Jan 10, 2021
styfle
reviewed
Jan 10, 2021
styfle
approved these changes
Jan 10, 2021
guybedford
force-pushed
the
custom-emit
branch
from
9fdba88
to
72fc9f6
Compare
guybedford
force-pushed
the
custom-emit
branch
from
a817a02
to
b4e8f29
Compare
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
customEmitoption from vercel/webpack-asset-relocator-loader#111 to ncc directly allow custom asset emission hooks.This PR is pending that update so the tests will be failing until then.