Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip typechecking on sub-builds #637

Merged
merged 1 commit into from Jan 6, 2021
Merged

fix: skip typechecking on sub-builds #637

merged 1 commit into from Jan 6, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 6, 2021

This PR is a performance optimization that skips type checking on a sub-asset build. This would've already been performed by the parent process.

@Timer Timer requested a review from styfle as a code owner January 6, 2021 17:48
@styfle styfle added the automerge Automatically merge PR once checks pass label Jan 6, 2021
@kodiakhq kodiakhq bot merged commit e2910fb into master Jan 6, 2021
@kodiakhq kodiakhq bot deleted the fix/skip-typecheck branch January 6, 2021 18:52
This was referenced Mar 11, 2021
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Merged
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
@Obi-Dann Obi-Dann mentioned this pull request Apr 10, 2021
Draft
@github-actions github-actions bot mentioned this pull request Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@styfle styfle styfle approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @styfle