Filenames of resources must be unique to avoid a crash

[baboons]

Considering the examples for NCC with Apollo and an abstract structure with schemas as resources and sharing the same filenames. This will cause NCC to compile the first/last file only, and throwing an error.

schemas\
      blogs\
           index.js
           schema.gql
      posts\
           index.js
           schema.gql

Output

   3kB  /schema.gql
6127kB  /index.js

At the moment this can only be resolved by renaming one of the schemas and make sure the file names are unique:

const typeDefs = String(fs.readFileSync(__dirname + "/schema2.gql"));

Output

   1kB  /schema2.gql
   3kB  /schema.gql
6127kB  /index.js

[TooTallNate]

Duplicating the original directory structure would be another way to solve it (would still require a rewrite of the output file path).

[guybedford]

There is deduping applied in https://github.com/zeit/ncc/blob/master/src/asset-relocator.js#L40 which should exactly be resulting in schema and schema1 being emitted.

I suspect this may actually be due to a static analysis failure as opposed to a deduping failure - where one is not being statically analyzed and the other is, but we won't know until we can verify the exact JS expression that loads both of these.

[guybedford]

@baboons do you have an exact replication here that we can look at?

[guybedford]

(duplicate assets are already unit tested in https://github.com/zeit/ncc/blob/master/test/unit/asset-fs-inlining-multi/input.js)

[rauchg]

I'll close until we hear from @baboons whether this is happening on 0.3.0+