You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. Unused css file in starter code
There is globals.css file in /styles directory from the very first starter learn-starter, all the way through assets-metadata-css-starter.
However the only css file that is imported & used in those starters is styles/Home.module.css, not styles/globals.css.
Are there any reasons that the file (globals.css) is included in those starters despite the fact it is not used?🤔
2. Potentially misleading guide
In addition, Assets, Metadata, and CSS tutorial mentions the presence of styles directory (+ and unused /globals.css file).
Although the starter used in tutorial already have styles directory as mentioned, tutorial guides us to create styles directory.
And at this point I was confused, since I already got globals.css file but tutorial guides me to create global.css which seems like a typo! (considering similarity of the name for those 2 file)
After this Assets, Metadata, and CSS tutorial, the unused globals.css file is gone, and only global.css file (that is used in pages/_app.js) remains.
So, my point is...
Is there any reason that unused globals.css exists?
If not, it would be nice and clear if it's removed from starters, and also from tutorial.
The text was updated successfully, but these errors were encountered:
I think that removal of the global style file might be an option, like @hanameee pointed out, it's not mentioned till later chapters. Another option would be just to rename the conflicting file, since it is simply a file name inconsistency. It'll still be present in the first chapters, but at least the name would be the same for later chapters.
In any case, we would want to consult @manovotny or @delbaoliveira to see what they have to say.
The remaining starter code chapters all use the singular naming convention styles/global.css
Based on this information, the simplest approach is to rename the styles filename for the first two starter code templates. I'll go ahead and open a PR to get things rolling 👌
Hi. Thanks for the great tutorial 👏
1. Unused css file in starter code
There is
globals.css
file in/styles
directory from the very first starter learn-starter, all the way through assets-metadata-css-starter.However the only css file that is imported & used in those starters is
styles/Home.module.css
, notstyles/globals.css
.Are there any reasons that the file (globals.css) is included in those starters despite the fact it is not used?🤔
2. Potentially misleading guide
In addition, Assets, Metadata, and CSS tutorial mentions the presence of
styles
directory (+ and unused/globals.css
file).Although the starter used in tutorial already have
styles
directory as mentioned, tutorial guides us to createstyles
directory.And at this point I was confused, since I already got
globals.css
file but tutorial guides me to createglobal.css
which seems like a typo! (considering similarity of the name for those 2 file)After this Assets, Metadata, and CSS tutorial, the unused
globals.css
file is gone, and onlyglobal.css
file (that is used inpages/_app.js
) remains.So, my point is...
globals.css
exists?The text was updated successfully, but these errors were encountered: