Router.push/replace ignores trailing spaces on the last query parameter (even if encoded as %20)

[renato]

Bug report

Describe the bug

Router.push/replace ignores trailing spaces on the last query parameter, even if already encoded (%20). Examples:

• Router.push("/?q=unencoded trailing ") results in query = { "q": "unencoded trailing" }
• Router.push(encodeURI("/?q=encoded trailing ")) results in query = { "q": "encoded trailing" }
• Router.push({ pathname: "/", query: { q: "unencoded trailing " } }) results in query = { "q": "unencoded trailing" }
• Router.push("/?q=unencoded trailing &add=trailing ") results in query = { "q": "unencoded trailing ", "add": "trailing" } (only the last param got stripped)

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

1. git clone https://github.com/renato/nextjs-using-router-trailing-space
2. npm install
3. npm run dev
4. Navigate through links

Expected behavior

The query object should consistently have the complete string, with the trailing spaces, even for the last parameter.

Screenshots

If applicable, add screenshots to help explain your problem.

System information

• OS: macOS 10.14.6
• Browser: Chrome 79.0.3945.88
• Version of Next.js: latest

Additional context

I don't know exactly what version changed the behavior, but this issue didn't happen some months ago.

[Timer]

This behavior changed in 9.1.5, working in 9.1.4.

[Timer]

04a7f1e is the first bad commit (long bisect process)

[Timer]

Upstream bug: GoogleChromeLabs/native-url#12

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.