Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme UI's MDX Components Not Rendering in 9.4 #13047

Closed
joe-bell opened this issue May 18, 2020 · 9 comments
Closed

Theme UI's MDX Components Not Rendering in 9.4 #13047

joe-bell opened this issue May 18, 2020 · 9 comments
Milestone

Comments

@joe-bell
Copy link
Contributor

Bug report

Describe the bug

In my project raam, I'm trying to upgrade to Next 9.4. Unfortunately my ThemeProvider (from Theme UI) is no longer applying components to MDX:

PR: joe-bell/raam#21
Demo: https://raam-git-chore-next-94.joebell.now.sh/

Is there something that needs to be done on my side/Theme UI's side to support fast refresh?

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Go to https://raam-git-chore-next-94.joebell.now.sh/

Expected behavior

The MDX content should render with the components I've defined, like the do with Next 9.3 in raam.joebell.co.uk

Screenshots

Before

Screenshot 2020-05-18 at 16 56 02

After

Screenshot 2020-05-18 at 16 55 51

System information

  • OS: macOS
  • Browser (if applies): N/A all browsers.
  • Version of Next.js: 9.4.1
  • Version of Node.js: 13.8.0
@joe-bell joe-bell changed the title Theme UI's MDX Components Don't Render in 9.4 Theme UI's MDX Components Not Rendering in 9.4 May 18, 2020
@Timer Timer added this to the 9.4.2 milestone May 18, 2020
@aizkhaj
Copy link

aizkhaj commented May 18, 2020

Hey @joe-bell, shooting in the dark here, but I recently came across this issue on next-mdx-enhanced, perhaps it may be connected? hashicorp/next-mdx-enhanced#53. I'm aware it's not the same package you're using for your mdx but it could be a related issue.

@joe-bell
Copy link
Contributor Author

Thanks for the heads up @aizkhaj, sounds like there's a possibility this could be related

@Timer Timer modified the milestones: 9.4.2, 9.4.3 May 20, 2020
@Timer Timer modified the milestones: 9.4.3, 9.4.4 May 28, 2020
@joe-bell
Copy link
Contributor Author

Digging into this a little more, I think it might be related to @next/mdx.

I was able to update a separate project using next-mdx-enhanced without a hitch, but this issue still remains in the repro provided on the latest version of Next.js

@Timer Timer modified the milestones: 9.4.5, 9.x.x Jun 29, 2020
@joe-bell
Copy link
Contributor Author

This appears to be fixed in 9.5! Thanks @Timer and team 🎉

9.4: https://raam-git-chore-next-94.joebell.vercel.app/
9.5.1: https://raam-git-dependabot-npmandyarnnext-951.joebell.vercel.app/

@jonashaefele
Copy link

@joe-bell any chance you can share a basic reproduction of your working setup? Or any hints on how you got it working? Seems to be very temperamental, still. I couldn't get it to work even with a fresh setup. And seems like others have the same problem. Might just be a single dependency version or so, I tried so many combinations over the last couple days. Any hints are greatly appreciated.

@joe-bell
Copy link
Contributor Author

@jonashaefele there are links to an example in the description 🙂

@jonashaefele
Copy link

Thanks @joe-bell! Maybe I'm blind today but I only found links to the deployment not the repo. But just realised the branch for it is still public on your raam repo, will have a dig through and compare to my config. Thanks!

@joe-bell
Copy link
Contributor Author

@jonashaefele no worries! Good luck and keep us posted

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants