with-sentry @sentry/webpack-plugin uploads previous build artifacts

[stovmascript]

Bug report

Describe the bug

In the with-sentry example, when @sentry/webpack-plugin is used for automatic sourcemap upload, it will include previous builds to the upload.

To Reproduce

1. Use the with-sentry example
2. Configure the app for automatic sourcemap upload
3. Run build multiple times
4. You should see the upload size increasing

Expected behavior

Only include current build artifacts in the upload to Sentry.

System information

• OS: macOS
• Version of Next.js: 9.4.4
• Version of Node.js: 12.16.1

Additional context

We're self hosting Sentry and in our case just a couple of builds of our app can result in a 500MB upload.

[jamesmosier]

Feel free to investigate and open up a PR 😄

[stovmascript]

I dug around before opening the issue and it could be resolved quite easily. @sentry/webpack-plugin allows specifying which files to include, but it would be great if somebody could point me to a reliable source of build output files.

I looked into the build-manifest.json that gets generated and it could be useful, but the problem is that this file is generated after files are built and @sentry/webpack-plugin needs to be configured at build time.

[stovmascript]

@jamesmosier That, or if there was somebody on the team or some doc that could help me understand the .next dir structure. I tried to observe how the dir changes across builds with build id, etc. I have some idea, but that still isn't helping me grab all needed build files (cached from previous builds & new ones).

[Multiply]

Not entirely related, but I had a similar issue when deploying to firebase, that all previous builds would be included.
I simply cleaned up the next directory before building and deploying production builds.

[stovmascript]

@Multiply Yeah, that fixes the duplicity problem, but it's a workaround which potentially creates other problems. I would like to avoid it and definitely not something I would introduce to the with-sentry example. There's a whole RFC #6009 dedicated to build dir cleaning and it's still open.

[stovmascript]

This seems to be solved in Next.js 11, with the new distDir cleaning. You can also now use the official @sentry/nextjs SDK (example).

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.