Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal next/link to #fragment does not correctly scroll to target #26780

Closed
tremby opened this issue Jun 30, 2021 · 3 comments
Closed

Internal next/link to #fragment does not correctly scroll to target #26780

tremby opened this issue Jun 30, 2021 · 3 comments
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity

Comments

@tremby
Copy link
Contributor

tremby commented Jun 30, 2021

What version of Next.js are you using?

11.0.1/11.0.2-canary.3

What version of Node.js are you using?

14.15.4

What browser are you using?

Firefox/Chrome

What operating system are you using?

Linux/MacOS

How are you deploying your application?

next dev/start/export

Describe the Bug

The docs say that next/link will honour the #fragment and scroll us to the target element on the destination page.

This doesn't appear to be working for me.

I'm sometimes getting scrolled to the very bottom of the destination page (nowhere near the target element, and this seems to be more common in Chrome), or sometimes to some other point in the page (both Firefox and Chrome).

I have determined that when I end up on some seemingly meaningless point on the target page, the window.scrollY is identical to where it was on the previous page when the link was clicked.

Expected Behavior

On the destination page, we end up with the targeted element at or near the top of the viewport.

To Reproduce

An example of the issue is at https://cesium.com/events/ which has been deployed via next export. I see the same issue when running next dev.

Near the very bottom of the page, click any of the yellow "view presentation" links, which point to fragments of a different page via next/link. The Earth Archive one, for example, should land us very near the top of the destination page, but I never land there; I usually land significantly further down the page.

In a dev console, check window.scrollY before and after the navigation -- I usually see that the number is identical, i.e. we have not changed scroll position at all.


I have been trying to debug this by putting debugger and console.log statements in the node_modules/next/dist/next-server/lib/router/router.js and node_modules/next/dist/client/link.js and restarting my dev server, but I can't seem to make anything change -- I see no logs and the debugger doesn't trip. I can even return early from those functions but they still act as if I haven't changed anything. I must be editing the wrong files. Meanwhile, using the debugger in Chrome or Firefox isn't allowing me to put a breakpoint anywhere useful -- it insists on putting it at the start of the file no matter whether sourcemaps are on or off, or I've got code prettifying on or off. Wonder what I'm doing wrong, but I'm stuck.

@tremby tremby added the bug Issue was opened via the bug report template. label Jun 30, 2021
@jankaifer jankaifer added the please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity label Nov 29, 2022
@jankaifer
Copy link
Contributor

Please verify that your issue can be recreated with next@canary.

Why was this issue marked with the please verify canary label?

We noticed the provided reproduction was using an older version of Next.js, instead of canary.

The canary version of Next.js ships daily and includes all features and fixes that have not been released to the stable version yet. You can think of canary as a public beta. Some issues may already be fixed in the canary version, so please verify that your issue reproduces by running npm install next@canary and test it in your project, using your reproduction steps.

If the issue does not reproduce with the canary version, then it has already been fixed and this issue can be closed.

How can I quickly verify if my issue has been fixed in canary?

The safest way is to install next@canary in your project and test it, but you can also search through closed Next.js issues for duplicates or check the Next.js releases.

My issue has been open for a long time, why do I need to verify canary now?

Next.js does not backport bug fixes to older versions of Next.js. Instead, we are trying to introduce only a minimal amount of breaking changes between major releases.

What happens if I don't verify against the canary version of Next.js?

An issue with the please verify canary that receives no meaningful activity (e.g. new comments that acknowledge verification against canary) will be automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue, with the required reproduction, using next@canary.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction (following the above steps). Furthermore, you can upvote the issue (using the 👍 reaction on the topmost comment, instead of commenting "I have the same issue" etc.). Then, we can sort issues by engagement to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Projects
None yet
Development

No branches or pull requests

3 participants