Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot code reloading checklist #30

Closed
8 tasks done
rauchg opened this issue Oct 17, 2016 · 1 comment
Closed
8 tasks done

Hot code reloading checklist #30

rauchg opened this issue Oct 17, 2016 · 1 comment

Comments

@rauchg
Copy link
Member

rauchg commented Oct 17, 2016

Some example scenarios to check

  • After making a change, server-rendering works as expected (bug)
  • Errors render on the browser as well (with our existing style)
  • Works with path registration / unregistration.
    • If I go to /test and test.js doesn't exist, render 404. Creating it renders test.js
    • If I create test.js but with an error, we replace the 404 with an error
    • If test.js has an error but I remove it, render 404
  • Handle the scenario correctly where the user-created error.js has an error (fallback + console.error in main terminal is acceptable for this)
  • Hot code reloading of error.js works when rendering an error
@rauchg rauchg added the blocker label Oct 17, 2016
@nkzawa
Copy link
Contributor

nkzawa commented Oct 19, 2016

about rendering compilation errors, it can display syntax highlight which babel adds if we want.

@nkzawa nkzawa closed this as completed Nov 3, 2016
@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants