Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEXT-565] can't get not-found.js in dynamic router #45939

Closed
1 task done
denisso opened this issue Feb 15, 2023 · 2 comments
Closed
1 task done

[NEXT-565] can't get not-found.js in dynamic router #45939

denisso opened this issue Feb 15, 2023 · 2 comments
Labels
bug Issue was opened via the bug report template.

Comments

@denisso
Copy link

denisso commented Feb 15, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

windows 10
node v18.13.0
"@next/font": "13.1.5",
"@types/node": "18.11.18",
"@types/react": "18.0.27",
"@types/react-dom": "18.0.10",
"classnames": "^2.3.2",
"eslint": "8.32.0",
"eslint-config-next": "13.1.5",
"moment": "^2.29.4",
"next": "^13.1.7-canary.14",
"react": "^18.2.0",
"react-dom": "18.2.0",
"typescript": "4.9.4"

Which area(s) of Next.js are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue

https://github.com/denisso/next13-app-exp/tree/router-dynamic

To Reproduce

To reproduce the problem, go to the "Dynamic Params false" section and select one of the gray links.

Describe the Bug

When 404 is triggered, the page is completely reloaded, and I get a 404 page which is the default.

Expected Behavior

get content not-found.js Instead of 404 page which is the default.

Which browser are you using? (if relevant)

Chrome

How are you deploying your application? (if relevant)

https://6951jo-3000.preview.csb.app/

NEXT-565

@denisso denisso added the bug Issue was opened via the bug report template. label Feb 15, 2023
@jankaifer jankaifer changed the title can't get not-found.js in dynamic router [NEXT-565] can't get not-found.js in dynamic router Feb 15, 2023
@jankaifer
Copy link
Contributor

not-found.tsx needs to be manually triggered with notFound(). It doesn't get triggered when you navigate to non-existing path.

We are working on that.

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

No branches or pull requests

2 participants